[webkit-reviews] review denied: [Bug 23147] Introduce Skia to WebKit : [Attachment 26507] Add remaining bits of platform/graphics/skia

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has denied Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 23147: Introduce Skia to WebKit
https://bugs.webkit.org/show_bug.cgi?id=23147

Attachment 26507: Add remaining bits of platform/graphics/skia
https://bugs.webkit.org/attachment.cgi?id=26507&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
I'd like this patch split up somewhat more.  Ideally basic graphic context
stuff separate from the font stuff, for that reaosn r- (Font stuff is
sufficiently complex for me to want someone else to review it, i don't know
whether it should just be r+'d as a platform component for instance, or whether
there are real rules that are necessary)


But other issues
WebCoreRectToSkiaRect, etc -> these should not be in SkieUtils, they should be
in IntRectSkia, etc as with the other ports
i'm not sure i like WebCoreCompositeToSkiaComposite, but i feel
GraphicsContextSkia would be best
I don't have a clue what the hell SkColor SkPMColorToColor(SkPMColor pm) things
are :D

In general *Utils files are bad, functions should be placed in the files of
appropriate relevance, eg. IntRectSkia, and so on and so forth.

Didn't look at style at all.