[webkit-reviews] review requested: [Bug 23116] [GTK] fix random libsoup crashes : [Attachment 26488] patch 1

[bugzilla-daemon at webkit.org]

Benjamin Otte <otte at gnome.org> has asked  for review:
Bug 23116: [GTK] fix random libsoup crashes
https://bugs.webkit.org/show_bug.cgi?id=23116

Attachment 26488: patch 1
https://bugs.webkit.org/attachment.cgi?id=26488&action=review

------- Additional Comments from Benjamin Otte <otte at gnome.org>
Yay, looks like I stepped right into all newcomer traps at once.

Anyway, I'm cleaning up the patch, and here's the first and uncontroversial
fix: keeping track of the idle source and removing it in the destructor.

For the second part the problem is more complex: It is not possible to remove
the async callback (yes, this is a bug in the GIO API), so the data passed to
the GIO callbacks must stay valid until this callback is called. The easiest
method is to just ref the ResourceHandle, but that means Webkit has no control
about the lifetime of the ResourceHandle. I'm going to prepare a patch for
that.