[webkit-reviews] review granted: [Bug 23126] Add DRT API to retrieve number of active animations from AnimationController : [Attachment 26481] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 6 17:35:29 PST 2009


Darin Adler <darin at apple.com> has granted Pierre-Olivier Latour
<pol at apple.com>'s request for review:
Bug 23126: Add DRT API to retrieve number of active animations from
AnimationController
https://bugs.webkit.org/show_bug.cgi?id=23126

Attachment 26481: Patch v1
https://bugs.webkit.org/attachment.cgi?id=26481&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +	   RefPtr<CompositeAnimation> compAnim = it->second;
> +	   count += compAnim->numberOfActiveAnimations();

This will unnecessarily churn the reference count of the animation. You should
either use a raw pointer for the local variable, or just use it->second
directly.

r=me


More information about the webkit-reviews mailing list