[webkit-reviews] review denied: [Bug 23147] Introduce Skia to WebKit : [Attachment 26470] Add WebCore/platform/graphics/skia files

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 6 14:27:41 PST 2009

Eric Seidel <eric at webkit.org> has denied Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 23147: Introduce Skia to WebKit

Attachment 26470: Add WebCore/platform/graphics/skia files

------- Additional Comments from Eric Seidel <eric at webkit.org>
AffineTransformSkia.cpp needs to be renamed to TransformationMatrixSkia.cpp
(and the class too) to match recent renames upstream.

I don't understand what GdkSkia.cpp is for.  Seems it should be in its own
separate patch.

WebKit style would use coundUsed instead of count_used

We don't use c-style casts in C++ code:
+    SkColor* colors = (SkColor*)storage.get();

GraphicsContextSkia needs its own patch.  It's too big to grok as part of this

Image buffer probably too.

== stopped reading ==

More information about the webkit-reviews mailing list