[webkit-reviews] review denied: [Bug 23116] [GTK] fix random libsoup crashes : [Attachment 26429] suggested fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 6 13:59:55 PST 2009


Eric Seidel <eric at webkit.org> has denied Benjamin Otte <otte at gnome.org>'s
request for review:
Bug 23116: [GTK] fix random libsoup crashes
https://bugs.webkit.org/show_bug.cgi?id=23116

Attachment 26429: suggested fix
https://bugs.webkit.org/attachment.cgi?id=26429&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
This needs a ChangeLog and should use spaces instead of tabs.  Please review
http://webkit.org/coding/coding-style.html

Is there no way to use a RefPtr here instead of manual ref/deref?  We try hard
to avoid manual ref/deref because it's very error prone.


More information about the webkit-reviews mailing list