[webkit-reviews] review granted: [Bug 23114] JSValue* should be replaced with a class type. : [Attachment 26447] revert emitLoad function name change & fix typo in ChangeLog.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jan 6 12:00:51 PST 2009
Oliver Hunt <oliver at apple.com> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 23114: JSValue* should be replaced with a class type.
https://bugs.webkit.org/show_bug.cgi?id=23114
Attachment 26447: revert emitLoad function name change & fix typo in ChangeLog.
https://bugs.webkit.org/attachment.cgi?id=26447&action=review
------- Additional Comments from Oliver Hunt <oliver at apple.com>
> + value now encapsulaed it will likely make sense to migrate the
functionality
tyop
Looks good, am only rubber stamping the rename portion of it, r=me on the
JSValuePtr (and EncodedAsPtr) conversion logic, assuming you've tested jit +
interpreter code paths, and perf is good
More information about the webkit-reviews
mailing list