[webkit-reviews] review granted: [Bug 22882] Make fast\encoding\char-encoding.html not depend on the ability to have reference fragments on data URLs : [Attachment 26437] updated patch with ap's review comments addressed
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jan 5 13:07:38 PST 2009
Jungshik Shin <jshin at chromium.org> has granted 's request for review:
Bug 22882: Make fast\encoding\char-encoding.html not depend on the ability to
have reference fragments on data URLs
https://bugs.webkit.org/show_bug.cgi?id=22882
Attachment 26437: updated patch with ap's review comments addressed
https://bugs.webkit.org/attachment.cgi?id=26437&action=review
------- Additional Comments from Jungshik Shin <jshin at chromium.org>
Moving r+ flag from the previous patch. I addressed ap's review comments:
I got rid of function names in ChangeLog.
I also left alone the UTF-8 test case (i.e. it's still commented out) because I
don't have an access to Tiger. I mistakenly thought that the issue was across
platforms and not using 'data' url would resolve it.
More information about the webkit-reviews
mailing list