[webkit-reviews] review granted: [Bug 22917] break out text selection on initial focus as separate feature : [Attachment 26122] patch to allow selecting all text on initial focus of text area

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Cary Clark <caryclark at google.com>'s
request for review:
Bug 22917: break out text selection on initial focus as separate feature
https://bugs.webkit.org/show_bug.cgi?id=22917

Attachment 26122: patch to allow selecting all text on initial focus of text
area
https://bugs.webkit.org/attachment.cgi?id=26122&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +#if !defined(ON_FIRST_TEXTAREA_FOCUS_SELECT_ALL)
> +#define ENABLE_ON_FIRST_TEXTAREA_FOCUS_SELECT_ALL 0
> +#endif

Seems slightly excessive to control this with Platform.h, but I suppose we can
refactor this when we refactor Platform.h in the future.

> +	   WARNING: NO TEST CASES ADDED OR CHANGED

Please remove this line from the ChangeLog. The warning is to you, the person
writing the ChangeLog, and shouldn't be checked in.

The ChangeLog should include the URL of this bug report.

r=me