[webkit-reviews] review granted: [Bug 23077] Make application cache use SQLite built-in user_version : [Attachment 26370] proposed patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 23077: Make application cache use SQLite built-in user_version
https://bugs.webkit.org/show_bug.cgi?id=23077

Attachment 26370: proposed patch
https://bugs.webkit.org/attachment.cgi?id=26370&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    if (static_cast<int>(sizeof(userVersionSQL)) < numBytes)
> +	   ASSERT_NOT_REACHED();

This is a strange way to write an assertion. Are you just trying to avoid the
unused local variable warning? Is there a better idiom for this sort of thing?
It seems to come up often.

r=me