[webkit-reviews] review granted: [Bug 23063] [jsfunfuzz] Assertion + incorrect behaviour with dynamically created local variable in a catch block : [Attachment 26344] Fix the creation of scopes for catch blocks containing eval

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 1 00:16:17 PST 2009


Cameron Zwarich (cpst) <cwzwarich at uwaterloo.ca> has granted Oliver Hunt
<oliver at apple.com>'s request for review:
Bug 23063: [jsfunfuzz] Assertion + incorrect behaviour with dynamically created
local variable in a catch block
https://bugs.webkit.org/show_bug.cgi?id=23063

Attachment 26344: Fix the creation of scopes for catch blocks containing eval
https://bugs.webkit.org/attachment.cgi?id=26344&action=review

------- Additional Comments from Cameron Zwarich (cpst)
<cwzwarich at uwaterloo.ca>
You have a typo in your ChangeLog. It should be

the catch block's static scope

rather than

the catch blocks static scope. You should also put the bool after the pointer
member variables in the class definition.

Other than that, r=me.


More information about the webkit-reviews mailing list