[webkit-reviews] review denied: [Bug 24253] Add functions to ChromiumBridge for profiler API control : [Attachment 28110] Patch v2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Feb 28 10:55:34 PST 2009
Darin Fisher (:fishd, Google) <darin at chromium.org> has denied Antony Sargent
<asargent at chromium.org>'s request for review:
Bug 24253: Add functions to ChromiumBridge for profiler API control
https://bugs.webkit.org/show_bug.cgi?id=24253
Attachment 28110: Patch v2
https://bugs.webkit.org/attachment.cgi?id=28110&action=review
------- Additional Comments from Darin Fisher (:fishd, Google)
<darin at chromium.org>
>Index: platform/chromium/ChromiumBridge.h
...
> // Widget
-------------------------------------------------------------
> static void widgetSetCursor(Widget*, const Cursor&);
> static void widgetSetFocus(Widget*);
>+
>+ // Profiler
-----------------------------------------------------------
>+ static void profilerStart();
>+ static void profilerStop();
>+ static void profilerClearData();
>+ static void profilerSetThreadName(const char *name);
one more stylistic problem that i forgot to mention... the groups in
ChromiumBridge are intentionally alphabetized, but this breaks that.
please sort them :)
also, please note that webkit style says to write |const char* name|
instead of |const char *name|. sorry for not making that more clear
in my previous review.
otherwise, this change LG. but please upload a clean patch. thanks!
More information about the webkit-reviews
mailing list