[webkit-reviews] review granted: [Bug 24256] Add a preference flag to force software animation : [Attachment 28107] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Chris Marrin
<cmarrin at apple.com>'s request for review:
Bug 24256: Add a preference flag to force software animation
https://bugs.webkit.org/show_bug.cgi?id=24256

Attachment 28107: Patch
https://bugs.webkit.org/attachment.cgi?id=28107&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog (revision 41308)
> +++ WebCore/ChangeLog (working copy)
> @@ -1,3 +1,19 @@
> +2009-02-27  Chris Marrin  <cmarrin at apple.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   https://bugs.webkit.org/show_bug.cgi?id=24256
> +
> +	   Added a WebCoreForceSoftwareAnimation flag.
> +
> +	   WARNING: NO TEST CASES ADDED OR CHANGED

Remove this before committing.

> Index: WebCore/platform/graphics/mac/GraphicsLayerCA.mm
> ===================================================================

> +static bool forceSoftwareAnimation()
> +{
> +    static int forceSoftwareAnimation = [[NSUserDefaults
standardUserDefaults] boolForKey:@"WebCoreForceSoftwareAnimation"];
> +    return forceSoftwareAnimation;
> +}

Feel free to change this and the other static ints to static bools. I have no
idea why they are ints.

r=me with those changes.