[webkit-reviews] review denied: [Bug 24253] Add functions to ChromiumBridge for profiler API control : [Attachment 28105] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <darin at chromium.org> has denied Antony Sargent
<asargent at chromium.org>'s request for review:
Bug 24253: Add functions to ChromiumBridge for profiler API control
https://bugs.webkit.org/show_bug.cgi?id=24253

Attachment 28105: Patch
https://bugs.webkit.org/attachment.cgi?id=28105&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<darin at chromium.org>
>Index: ChangeLog

>+2009-02-27  Antony Sargent  <asargent at chromium.org>
>+
>+	  Reviewed by NOBODY (OOPS!).
>+
>+	  Add functions to ChromiumBridge for profiler API control (eg
Quantify) 
>+
>+	  * platform/chromium/ChromiumBridge.h:

nit: please include a bug link in the ChangeLog.


>Index: platform/chromium/ChromiumBridge.h

>+	  // PerformanceProfiler
------------------------------------------------
>+	  static void performanceProfilerStart();

nit: wouldn't it be sufficient to just use the prefix "profiler"?  usually a
profiler has to do with performance.


>+	  static void performanceProfilerSetThreadName(char *name);

nit: that should be (const char* name)