[webkit-reviews] review granted: [Bug 24227] Implement checkForSolidColor in ImageQt.cpp : [Attachment 28097] Implements the Qt version and also fixes a bug in x-platform version

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Treat <treat at kde.org>'s request
for review:
Bug 24227: Implement checkForSolidColor in ImageQt.cpp
https://bugs.webkit.org/show_bug.cgi?id=24227

Attachment 28097: Implements the Qt version and also fixes a bug in x-platform
version
https://bugs.webkit.org/attachment.cgi?id=28097&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
if (!m_checkedForSolidColor) checkForSolidColor(); should be two lines. 
Otherwise looks good.

You shoudl add an ASSERT to mayFillWithSolidColor() and explain somewhere why
this works with images which are not loaded yet.  Perhaps in teh header next to
checkForSolidColor() // this shoudl check regardless of whether
m_checkedForSolidColor is set, as the frame may have changed.