[webkit-reviews] review granted: [Bug 24221] [GTK] Do not emit load-finished when being disposed : [Attachment 28067] disposing.patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Xan Lopez
<xan.lopez at gmail.com>'s request for review:
Bug 24221: [GTK] Do not emit load-finished when being disposed
https://bugs.webkit.org/show_bug.cgi?id=24221

Attachment 28067: disposing.patch
https://bugs.webkit.org/attachment.cgi?id=28067&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
r=me

> +    /*
> +	* We can get a stopLoad() from dispose when the object is being
> +	* destroyed, don't emit the signal in that case.
> +	*/

We prefer C++-style comments in C++ files.

Is this check needed before other g_signal_emit_by_name() calls?