[webkit-reviews] review requested: [Bug 19221] ASSERT during Range creation (due to editing commands) : [Attachment 28043] First pass renaming

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has asked  for review:
Bug 19221: ASSERT during Range creation (due to editing commands)
https://bugs.webkit.org/show_bug.cgi?id=19221

Attachment 28043: First pass renaming
https://bugs.webkit.org/attachment.cgi?id=28043&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
 LayoutTests/ChangeLog				    |	24 +++++
 .../editing/assert-on-range-creation-expected.txt  |	 1 +
 LayoutTests/editing/assert-on-range-creation.html  |	12 +++
 WebCore/ChangeLog				    |  105 ++++++++++++++++++++
 WebCore/WebCore.base.exp			    |	 5 +-
 WebCore/WebCore.xcodeproj/project.pbxproj	    |	 2 +-
 WebCore/dom/Position.cpp			    |	54 +++++++++-
 WebCore/dom/Position.h 			    |	52 ++++++----
 WebCore/dom/Range.cpp				    |	 8 +-
 WebCore/dom/RangeBoundaryPoint.h		    |	48 +++++-----
 WebCore/editing/ApplyStyleCommand.cpp		    |	 4 +-
 WebCore/editing/CompositeEditCommand.cpp	    |	12 +-
 WebCore/editing/DeleteSelectionCommand.cpp	    |	24 +++---
 WebCore/editing/Editor.cpp			    |	 4 +-
 WebCore/editing/InsertLineBreakCommand.cpp	    |	 2 +-
 .../editing/InsertParagraphSeparatorCommand.cpp    |	 6 +-
 WebCore/editing/ReplaceSelectionCommand.cpp	    |	 2 +-
 WebCore/editing/VisiblePosition.cpp		    |	57 +++++------
 WebCore/editing/VisiblePosition.h		    |	 4 +-
 WebCore/editing/VisibleSelection.cpp		    |	12 +-
 WebCore/editing/htmlediting.cpp		    |	64 +++++-------
 WebCore/editing/htmlediting.h			    |	 3 +-
 WebCore/editing/visible_units.cpp		    |	68 ++++++-------
 WebCore/page/DOMSelection.cpp			    |	16 ++--
 WebKit/mac/ChangeLog				    |	24 +++++
 WebKit/mac/WebView/WebFrame.mm 		    |	 9 +-
 26 files changed, 410 insertions(+), 212 deletions(-)