[webkit-reviews] review granted: [Bug 23957] SVG text gradients and patterns on chromium/skia don't work : [Attachment 28039] Revised: don't use "get" for getters; trim extraneous braces
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Feb 26 14:44:00 PST 2009
Eric Seidel <eric at webkit.org> has granted 's request for review:
Bug 23957: SVG text gradients and patterns on chromium/skia don't work
https://bugs.webkit.org/show_bug.cgi?id=23957
Attachment 28039: Revised: don't use "get" for getters; trim extraneous braces
https://bugs.webkit.org/attachment.cgi?id=28039&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
I'm not a huge fan of adding the accessors, but they don't really do any harm
either.
Looks fine. FYI, be sure to mark your patches r=? so that they get reviewed.
If you don't set review = ? then they just will get ignored. ;)
http://webkit.org/quality/lifecycle.html
has more information on how the process works.
More information about the webkit-reviews
mailing list