[webkit-reviews] review denied: [Bug 23957] SVG text gradients and patterns on chromium/skia don't work : [Attachment 28037] Revised: save & restore shader matrix, add comments, fix bad merge

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied 's request for review:
Bug 23957: SVG text gradients and patterns on chromium/skia don't work
https://bugs.webkit.org/show_bug.cgi?id=23957

Attachment 28037: Revised:  save & restore shader matrix, add comments, fix bad
merge
https://bugs.webkit.org/attachment.cgi?id=28037&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I don't think getters are named with "get" in WebKIt.  Also extra { } here:

5     } else if (pattern) {
 286	     shader = pattern->createPlatformPattern(transformationMatrix);
 287	 }


Yup:
Precede setters with the word "set". Use bare words for getters. Setter and
getter names should match the names of the variables being set/gotten.
http://webkit.org/coding/coding-style.html