[webkit-reviews] review requested: [Bug 24048] extra windows button padding doesn't apply when there's no appearance : [Attachment 28032] Replace adjustButtonInnerStyle with buttonInternalPaddingLeft/Right/Top/Bottom.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 26 12:51:11 PST 2009


Ojan Vafai <ojan at chromium.org> has asked  for review:
Bug 24048: extra windows button padding doesn't apply when there's no
appearance
https://bugs.webkit.org/show_bug.cgi?id=24048

Attachment 28032: Replace adjustButtonInnerStyle with
buttonInternalPaddingLeft/Right/Top/Bottom.
https://bugs.webkit.org/attachment.cgi?id=28032&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
 WebCore/ChangeLog			      |   34 ++++++++++++++++++++++++++
 WebCore/rendering/RenderButton.cpp	      |    7 ++++-
 WebCore/rendering/RenderTheme.cpp	      |    4 ---
 WebCore/rendering/RenderTheme.h	      |    8 ++++-
 WebCore/rendering/RenderThemeChromiumGtk.cpp |   23 +++++++++++++----
 WebCore/rendering/RenderThemeChromiumGtk.h   |    5 +++-
 WebCore/rendering/RenderThemeChromiumWin.cpp |   23 +++++++++++++----
 WebCore/rendering/RenderThemeChromiumWin.h   |    5 +++-
 WebCore/rendering/RenderThemeWin.cpp	      |   23 +++++++++++++----
 WebCore/rendering/RenderThemeWin.h	      |    5 +++-
 10 files changed, 108 insertions(+), 29 deletions(-)


More information about the webkit-reviews mailing list