[webkit-reviews] review requested: [Bug 17176] [GTK] API: hovering-over-link and webkit_web_view_open /_load_foo : [Attachment 28030] Support file paths in _open for compatibility

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 26 12:28:35 PST 2009


Christian Dywan <christian at imendio.com> has asked  for review:
Bug 17176: [GTK] API: hovering-over-link and webkit_web_view_open /_load_foo
https://bugs.webkit.org/show_bug.cgi?id=17176

Attachment 28030: Support file paths in _open for compatibility
https://bugs.webkit.org/attachment.cgi?id=28030&action=review

------- Additional Comments from Christian Dywan <christian at imendio.com>
As discussed, webkit_web_view_open used to support local paths until very
recently and some applications rely on this.

So this patch adds a test if the string is actually a local path. We are not
changing webkit_web_view_load_uri because that function is new and we don't
really encourage this kind of "guessing" on WebKit's side.

I tested it with devhelp, which doesn't show any content anymore due to this
regression. Another example would be liferea.


More information about the webkit-reviews mailing list