[webkit-reviews] review granted: [Bug 16947] [GTK] Missing HTTP Auth challenge : [Attachment 28027] keyringv3.patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Feb 26 11:52:39 PST 2009
Holger Freyther <zecke at selfish.org> has granted 's request for review:
Bug 16947: [GTK] Missing HTTP Auth challenge
https://bugs.webkit.org/show_bug.cgi?id=16947
Attachment 28027: keyringv3.patch
https://bugs.webkit.org/attachment.cgi?id=28027&action=review
------- Additional Comments from Holger Freyther <zecke at selfish.org>
> + GtkWidget* toplevel;
> + GtkWidget *widget;
> + GtkDialog *dialog;
> + GtkWindow *window;
> + GtkWidget *entryContainer;
> + GtkWidget *hbox, *mainVBox, *vbox, *icon;
> + GtkWidget *table;
> + GtkWidget *messageLabel;
> + char* message;
> + SoupURI* uri;
> +#if USE(GNOMEKEYRING)
> + GtkWidget* rememberBox;
> + GtkWidget* checkButton;
> +#endif
>
minor inconsistency... pick one, stay with it here :)
More information about the webkit-reviews
mailing list