[webkit-reviews] review requested: [Bug 23973] Chromium crashes at times when the view is being closed. : [Attachment 28024] Updated patch with the indentation fixed.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 26 11:22:55 PST 2009


Ananta Iyengar <ananta at chromium.org> has asked	for review:
Bug 23973: Chromium crashes at times when the view is being closed.
https://bugs.webkit.org/show_bug.cgi?id=23973

Attachment 28024: Updated patch with the indentation fixed.
https://bugs.webkit.org/attachment.cgi?id=28024&action=review

------- Additional Comments from Ananta Iyengar <ananta at chromium.org>
The functions in ScrollView.cpp reachable from ~FrameView are as below:-
1. ScrollView::setScrollbarModes which calls into updateScrollbars and ends up 
 
   in scrollcontents where hostwindow is dereferenced.

2. ScrollView::setHasHorizontalScrollbar and 
   ScrollView::setHasVerticalScrollbar.
   These functions internally call ScrollView::removeChild. They don't
reference
   hostWindow().


More information about the webkit-reviews mailing list