[webkit-reviews] review denied: [Bug 23973] Chromium crashes at times when the view is being closed. : [Attachment 27699] Initial attempt at a patch for this issue

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <darin at chromium.org> has denied Ananta Iyengar
<ananta at chromium.org>'s request for review:
Bug 23973: Chromium crashes at times when the view is being closed.
https://bugs.webkit.org/show_bug.cgi?id=23973

Attachment 27699: Initial attempt at a patch for this issue
https://bugs.webkit.org/attachment.cgi?id=27699&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<darin at chromium.org>
>Index: WebCore/platform/ScrollView.cpp
...
> void ScrollView::scrollContents(const IntSize& scrollDelta)
> {
>+    if (!hostWindow())
>+	return;
>+

nit: the return statement should be indented by 4 spaces.  R- because
of this.

ScrollView appears to be designed with the assumption that the hostWindow
will never be null, but I can see from the callstack that assumption seems
to be invalid.	So, I think your solution is probably the best we can do.

Are any of the other ScrollView methods reachable from ~FrameView?