[webkit-reviews] review denied: [Bug 24040] It should be possible to refresh items in the inspector's databases panel : [Attachment 28020] Move the refresh button to the views

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 26 10:47:54 PST 2009


Timothy Hatcher <timothy at hatcher.name> has denied Yael
<yael.aharon at nokia.com>'s request for review:
Bug 24040: It should be possible to refresh items in the inspector's databases
panel
https://bugs.webkit.org/show_bug.cgi?id=24040

Attachment 28020: Move the refresh button to the views
https://bugs.webkit.org/attachment.cgi?id=28020&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
> +	   this.refreshButton.removeStyleClass("hidden");
> +	   this.refreshButton.addStyleClass("hidden");

Why do you need to show/hide the button? Isn't this done by showing/hiding the
whole storageViewStatusBarItemsContainer now?

> +	   this.show();

It would be nice to have a refresh() function, calling show() again might do
more than we want in the future.


More information about the webkit-reviews mailing list