[webkit-reviews] review granted: [Bug 24202] drawNodeHighlight assumes the highlight is drawn in it's own buffer : [Attachment 28021] Have drawNodeHighlight clip instead of clearing. This makes it work for both Safari and Chromium since Chromium draws the inspector highlighting in the same buffer as the page.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 26 10:36:05 PST 2009


Adam Roben (aroben) <aroben at apple.com> has granted Ojan Vafai
<ojan at chromium.org>'s request for review:
Bug 24202: drawNodeHighlight assumes the highlight is drawn in it's own buffer
https://bugs.webkit.org/show_bug.cgi?id=24202

Attachment 28021: Have drawNodeHighlight clip instead of clearing. This makes
it work for both Safari and Chromium since Chromium draws the inspector
highlighting in the same buffer as the page.
https://bugs.webkit.org/attachment.cgi?id=28021&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> +	   WARNING: NO TEST CASES ADDED OR CHANGED

You should remove this line from your ChangeLog, perhaps replacing it with an
explanation (e.g., that there's no change in behavior and it's covered by
existing manual Inspector tests).

r=me


More information about the webkit-reviews mailing list