[webkit-reviews] review granted: [Bug 16947] [GTK] Missing HTTP Auth challenge : [Attachment 27731] keyring.patch

[bugzilla-daemon at webkit.org]

Holger Freyther <zecke at selfish.org> has granted Xan Lopez
<xan.lopez at gmail.com>'s request for review:
Bug 16947: [GTK] Missing HTTP Auth challenge
https://bugs.webkit.org/show_bug.cgi?id=16947

Attachment 27731: keyring.patch
https://bugs.webkit.org/attachment.cgi?id=27731&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>

> +	   Frame* m_frame;

To use RefPtr or not to use it. Can the Frame be removed during a request? This
might be a source of a crash, but we can go for wait and see.

>  
> +    // Used to set the authentication dialog toplevel; may be NULL
> +    d->m_frame = frame;
> +

maybe move the comment to the header file?


*skipped widget foo*