[webkit-reviews] review granted: [Bug 17585] [gtk] get|set encoding api : [Attachment 27827] encoding.patch

[bugzilla-daemon at webkit.org]

Holger Freyther <zecke at selfish.org> has granted Xan Lopez
<xan.lopez at gmail.com>'s request for review:
Bug 17585: [gtk] get|set encoding api
https://bugs.webkit.org/show_bug.cgi?id=17585

Attachment 27827: encoding.patch
https://bugs.webkit.org/attachment.cgi?id=27827&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>

> +    if (!overrideEncoding.isEmpty()) {
> +	 WebKitWebViewPrivate* priv = webView->priv;
> +	 g_free (priv->customEncoding);
> +	 priv->customEncoding = g_strdup(overrideEncoding.utf8().data());
> +	 return priv->customEncoding;
> +    } else
> +	 return NULL;
> +}

looks like two style issues here. "g_free (" and two instead of four spaces to
indent... please fix when landing.