[webkit-reviews] review granted: [Bug 20358] [Gtk] font-variant: small-caps; is not working with libwebkit-1.0-1 : [Attachment 27607] possible fix

[bugzilla-daemon at webkit.org]

Holger Freyther <zecke at selfish.org> has granted Jonathon Jongsma (jonner)
<jonathon at quotidian.org>'s request for review:
Bug 20358: [Gtk] font-variant: small-caps; is not working with libwebkit-1.0-1
https://bugs.webkit.org/show_bug.cgi?id=20358

Attachment 27607: possible fix
https://bugs.webkit.org/attachment.cgi?id=27607&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>

> -	   desc.setSpecifiedSize(0.70f*fontDescription.computedSize());
> +	   desc.setComputedSize(0.70f*fontDescription.computedSize());
	   const FontPlatformData* pdata = new FontPlatformData(desc,
desc.family().family());

Cool, what is completely missing from the ChangeLog is the answer to the
question why this is the right fix. The FontPlatformData c'tor will use the
computedPixelSize of the FontDescription so we will have to set the
ComputedSize (like your patch does) and it also makes this statement look
symmetric... (just scaling..). Taking a look at Mac and Win there might be more
work ahead for custom fonts. I don't have a test case handy but we should be
able to locate one.