[webkit-reviews] review granted: [Bug 24143] Crash occurs at WebCore::AccessibilityTable::isTableExposableThroughAccessibility() when applying a link in GMail : [Attachment 27954] patch to fix crash

[bugzilla-daemon at webkit.org]

Beth Dakin <bdakin at apple.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 24143: Crash occurs at
WebCore::AccessibilityTable::isTableExposableThroughAccessibility() when
applying a link in GMail
https://bugs.webkit.org/show_bug.cgi?id=24143

Attachment 27954: patch to fix crash
https://bugs.webkit.org/attachment.cgi?id=27954&action=review

------- Additional Comments from Beth Dakin <bdakin at apple.com>
Hey Chris! This patch looks good. My only comments really have to go with
naming conventions. I am not wild about the names get() and getIfExists(). How
about one of the following:

get() = getOrCreate()
getIfExists() = get()

or

get() = add()
getIfExists() = get()

The add() one is a little weird, I know, but that is a common naming convention
for this kind of thing is some other parts of WebCore…basically it means add
this to the cache or just return it if it already exists. That being said, I
like getOrCreate() as well, so you can choose whichever you prefer.