[webkit-reviews] review granted: [Bug 23854] DumpRenderTree window needs to be autodisplaying when displaying accelerated content : [Attachment 27499] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 25 11:55:21 PST 2009


mitz at webkit.org has granted Simon Fraser (smfr) <simon.fraser at apple.com>'s
request for review:
Bug 23854: DumpRenderTree window needs to be autodisplaying when displaying
accelerated content
https://bugs.webkit.org/show_bug.cgi?id=23854

Attachment 27499: Patch
https://bugs.webkit.org/attachment.cgi?id=27499&action=review

------- Additional Comments from mitz at webkit.org
In pointers to Objective-C instances, the space should go before the *
(including in static_cast<>s). I am not sure why you are checking that the
WebView responds to _isUsingAcceleratedCompositing. DumpRenderTree is not
expected to be used with old WebKit.

You don't need to declare and initialize the firstView variable outside the if
statement.

r=me


More information about the webkit-reviews mailing list