[webkit-reviews] review granted: [Bug 24066] Chromium drop-down box: selected items don't paint correctly when scrolled : [Attachment 27966] Updated patch that invalidates in the parent coordinates.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 25 08:50:21 PST 2009


Darin Fisher (:fishd, Google) <darin at chromium.org> has granted Jay Campan
<jcampan at google.com>'s request for review:
Bug 24066: Chromium drop-down box: selected items don't paint correctly when
scrolled
https://bugs.webkit.org/show_bug.cgi?id=24066

Attachment 27966: Updated patch that invalidates in the parent coordinates.
https://bugs.webkit.org/attachment.cgi?id=27966&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<darin at chromium.org>
>Index: WebCore/ChangeLog
...
>+	  Reviewed by NOBODY (OOPS!).
>+
>+	https://bugs.webkit.org/show_bug.cgi?id=24066
>+
>+	Items in drop-downs were not painted correctly.
>+	Makes sure the PopupListBox invalidates in the coordinates of
>+	the window as this is FramelessScrollView::invalidateRect
>+	paints to.

the ChangeLog has tabs in it.  those should be replaced with spaces.

otherwise, looks great!


More information about the webkit-reviews mailing list