[webkit-reviews] review requested: [Bug 24142] Add test for custom DOM properties surviving garbage collection : [Attachment 27965] Patch addressing Darin's comments

[bugzilla-daemon at webkit.org]

Pam Greene <pam at chromium.org> has asked  for review:
Bug 24142: Add test for custom DOM properties surviving garbage collection
https://bugs.webkit.org/show_bug.cgi?id=24142

Attachment 27965: Patch addressing Darin's comments
https://bugs.webkit.org/attachment.cgi?id=27965&action=review

------- Additional Comments from Pam Greene <pam at chromium.org>
Adjusted the comment on CollectGarbage() and renamed should_survive.

(In reply to comment #3)
> Good tests work in browser, too - see e.g. fast/workers/worker-gc.html for a
> technique that we use. Decent tests do print a warning.

Sorry, but I don't follow what you're requesting. This test uses the same
technique of allocating objects, which works in Safari and Firefox but not
Chromium (not V8, really); I don't know about other JS engines. It also prints
a form of warning, up in the test description: "Results may be different when
run manually...."  Is more than that needed?