[webkit-reviews] review granted: [Bug 23688] ThreadableLoader needs a sync implementation for Workers. : [Attachment 27962] Part 2: Add the sync implementation for Workers.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Feb 25 03:38:33 PST 2009
Alexey Proskuryakov <ap at webkit.org> has granted David Levin
<levin at chromium.org>'s request for review:
Bug 23688: ThreadableLoader needs a sync implementation for Workers.
https://bugs.webkit.org/show_bug.cgi?id=23688
Attachment 27962: Part 2: Add the sync implementation for Workers.
https://bugs.webkit.org/attachment.cgi?id=27962&action=review
------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
void ThreadableLoader::loadResourceSynchronously(ScriptExecutionContext*
context, const ResourceRequest& request, ThreadableLoaderClient& client)
{
ASSERT(context);
+
+#if ENABLE(WORKERS)
+ if (context->isWorkerContext())
+ return
WorkerThreadableLoader::loadResourceSynchronously(static_cast<WorkerContext*>(c
ontext), request, client);
Even though this works, I'd put "return" on a separate line.
+ ContentSniff contentSniff = request.url().isLocalFile() ? SniffContent :
DoNotSniffContent;
Two spaces after "=".
r=me
More information about the webkit-reviews
mailing list