[webkit-reviews] review denied: [Bug 24142] Add test for custom DOM properties surviving garbage collection : [Attachment 27942] New test + result

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <darin at chromium.org> has denied Pam Greene
<pam at chromium.org>'s request for review:
Bug 24142: Add test for custom DOM properties surviving garbage collection
https://bugs.webkit.org/show_bug.cgi?id=24142

Attachment 27942: New test + result
https://bugs.webkit.org/attachment.cgi?id=27942&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<darin at chromium.org>
>Index: fast/dom/Window/customized-property-survives-gc.html
...
>+function CollectGarbage() {
>+  if (window.GCController) {
>+    // This method is not available in Chromium, only in its test_shell.

It's also true that window.GCController is undefined in Safari.  From the
perspective of the WebKit project, it may be better to just say that this
method is only available when executed from DumpRenderTree.  That said,
it may not really be worth commenting here since other similar tests do
not have these kinds of comments.


>+function check(name, should_survive) {
>+  window[name].myProp = 10;
>+  CollectGarbage();
>+  if (should_survive)

nit: should_survive -> shouldSurvive