[webkit-reviews] review requested: [Bug 24131] Unfork RefCounting fix-ups : [Attachment 27925] Fix-up COM/RefCounted dichotomy in Chromium port, v1.

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <darin at chromium.org> has asked  for review:
Bug 24131: Unfork RefCounting fix-ups
https://bugs.webkit.org/show_bug.cgi?id=24131

Attachment 27925: Fix-up COM/RefCounted dichotomy in Chromium port, v1.
https://bugs.webkit.org/attachment.cgi?id=27925&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<darin at chromium.org>
>diff --git a/WebCore/page/chromium/AccessibilityObjectWrapper.h
b/WebCore/page/chromium/AccessibilityObjectWrapper.h
>index 9920e4d..af32567 100644
>--- a/WebCore/page/chromium/AccessibilityObjectWrapper.h
>+++ b/WebCore/page/chromium/AccessibilityObjectWrapper.h
>@@ -39,7 +39,14 @@ namespace WebCore {
> 
>     protected:
>	  AccessibilityObjectWrapper(AccessibilityObject* obj)
>-	      : RefCounted<AccessibilityObjectWrapper>(0), m_object(obj) { }
>+	      : m_object(obj)
>+	  {
>+	    // Default refCount is 1, but the webkit-win version of this is not

>+	    // RefCounted, so this is not properly created using ::create.
>+	    // FIXME: Once AccessibleBase no longer implements COM interfaces,
>+	    // make it not RefCounted.

This comment is a bit confusing.  The PLATFORM(WIN)
AccessibilityObjectWrapper class does inherit from
IUnknown, so it does do initialized-to-zero reference
counting as well.

Perhaps the comment can be:

// FIXME: Remove this once our immediate subclass no longer uses COM.


Otherwise, looks good.

-Darin