[webkit-reviews] review granted: [Bug 23740] table-layout: fixed overflow not painted in normal order : [Attachment 27940] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 24 16:01:35 PST 2009


Eric Seidel <eric at webkit.org> has granted Dave Hyatt <hyatt at apple.com>'s
request for review:
Bug 23740: table-layout: fixed overflow not painted in normal order
https://bugs.webkit.org/show_bug.cgi?id=23740

Attachment 27940: Patch
https://bugs.webkit.org/attachment.cgi?id=27940&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
The changelog doens't mention your isMask() changes.  your test cases are
missing newlines at the end.  you added some spaces after
shouldBeNormalFlowOnly which you didn't mean to.

Otherwise this looks fine, as far as I can tell.  You'll need a ChangeLog for
the LayoutTests directory as well.


More information about the webkit-reviews mailing list