[webkit-reviews] review requested: [Bug 24089] ThreadableLoader::loadResourceSynchronously should do callbacks like the async code. : [Attachment 27928] Proposed fix.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 24 13:27:07 PST 2009


David Levin <levin at chromium.org> has asked  for review:
Bug 24089: ThreadableLoader::loadResourceSynchronously should do callbacks like
the async code.
https://bugs.webkit.org/show_bug.cgi?id=24089

Attachment 27928: Proposed fix.
https://bugs.webkit.org/attachment.cgi?id=27928&action=review

------- Additional Comments from David Levin <levin at chromium.org>
For now, I've change the patch to not throw an exception when there is a
redirect failure due to a security issue which seemed consistent with IE and
FF, but I've sent an email about this issue and can easy change this aspect of
the behavior in the future.


I left the log message as html format not because I needed it but because it
seemed simpler.  (I didn't find a built in js function to escape text and (to
my memory) innerText didn't work in FF.)


More information about the webkit-reviews mailing list