[webkit-reviews] review granted: [Bug 24128] Upstream more V8 custom bindings : [Attachment 27924] Upstream move V8 custom bindings, v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 24 11:56:27 PST 2009


Eric Seidel <eric at webkit.org> has granted Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 24128: Upstream more V8 custom bindings
https://bugs.webkit.org/show_bug.cgi?id=24128

Attachment 27924: Upstream move V8 custom bindings, v1
https://bugs.webkit.org/attachment.cgi?id=27924&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
It looks fine so long as all your return v8:Undefined() calls have been checked
to make sure they shouldn't be return doNotIntercept() or whatever the current
name is.

Also, you're missing a newline at end of file in at least one file.


More information about the webkit-reviews mailing list