[webkit-reviews] review granted: [Bug 24096] Use PLATFORM(CF) instead of PLATFORM(MAC) in CurrentTime.cpp : [Attachment 27883] Address aroben's comments from previous patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 23 09:10:37 PST 2009


Adam Roben (aroben) <aroben at apple.com> has granted Jeremy Moskovich
<playmobil at google.com>'s request for review:
Bug 24096: Use PLATFORM(CF) instead of PLATFORM(MAC) in CurrentTime.cpp
https://bugs.webkit.org/show_bug.cgi?id=24096

Attachment 27883: Address aroben's comments from previous patch
https://bugs.webkit.org/attachment.cgi?id=27883&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> +#elif PLATFORM(GTK)
> +
> +// Note: GTK on Windows will pick up the PLATFORM(WIN) implementation above
which provides
> +// better accuracy compared with Windows implementation of
g_get_current_time:
> +//
(http://www.google.com/codesearch/p?hl=en#HHnNRjks1t0/glib-2.5.2/glib/gmain.c&q
=g_get_current_time).
> +// Non-Windows GTK builds could use gettimeofday() directly but for the sake
of consistency lets use GTK function.

Looks like this patch helps out GTK/win, too!

r=me


More information about the webkit-reviews mailing list