[webkit-reviews] review granted: [Bug 24089] ThreadableLoader::loadResourceSynchronously should do callbacks like the async code. : [Attachment 27876] Proposed fix.

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted David Levin
<levin at chromium.org>'s request for review:
Bug 24089: ThreadableLoader::loadResourceSynchronously should do callbacks like
the async code.
https://bugs.webkit.org/show_bug.cgi?id=24089

Attachment 27876: Proposed fix.
https://bugs.webkit.org/attachment.cgi?id=27876&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
I don't see where identifier changes from std::numeric_limits<unsigned
long>::max() to a real one now. I think that the fix is just to assign the
return value of FrameLoader::loadResourceSynchronously() to it.

+ function log(htmlMessage)

This looks like overkill. You don't ever pass HTML-formatted messages to this
function, do you?

r=me with two conditions:
1) Please test that Web Inspector still displays XHR responses correctly.
2) Please verify that the change in behavior matches other browsers, not just
the spec.