[webkit-reviews] review granted: [Bug 23956] Safari crashes when cloneNode fails (cloning a XML element with an invalid nodeName) : [Attachment 27857] Proposed fix: call Document::createElement(const QualifiedName&, bool) that does not checks. Also removed HTMLElement::cloneNode specialisation.

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 23956: Safari crashes when cloneNode fails (cloning a XML element with an
invalid nodeName)
https://bugs.webkit.org/show_bug.cgi?id=23956

Attachment 27857: Proposed fix: call Document::createElement(const
QualifiedName&, bool) that does not checks. Also removed HTMLElement::cloneNode
specialisation.
https://bugs.webkit.org/attachment.cgi?id=27857&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
I think this is fine. r=me

I think we should go even further and now that cloneElement doesn't have to be
virtual, move the code into cloneElement and have cloneNode call cloneElement
nstead of the other way around.