[webkit-reviews] review denied: [Bug 24043] [GTK] Workers with url 'about:blank' do not load : [Attachment 27844] Report errors through an idle function when faced unsupported URL protocols

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 24043: [GTK] Workers with url 'about:blank' do not load
https://bugs.webkit.org/show_bug.cgi?id=24043

Attachment 27844: Report errors through an idle function when faced unsupported
URL protocols
https://bugs.webkit.org/attachment.cgi?id=27844&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
> +    ResourceHandle* handle = static_cast<ResourceHandle*>(callback_data);
> +    if (!handle)
> +	   return FALSE;

I don't see how the handle can possibly be null. The callback data is set to
"this" in start(), and can't be modified by WebCore.

Looks like you need to ref() the handle when creating an idle handler, and
deref it when reportError() is done.