[webkit-reviews] review granted: [Bug 24063] Allow port to require a user gesture to play/pause an <audio> or <video> element : [Attachment 27836] revised patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 24063: Allow port to require a user gesture to play/pause an <audio> or
<video> element
https://bugs.webkit.org/show_bug.cgi?id=24063

Attachment 27836: revised patch
https://bugs.webkit.org/attachment.cgi?id=27836&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
> Index: WebCore/html/HTMLMediaElement.cpp
> ===================================================================

>  void HTMLMediaElement::togglePlayState(ExceptionCode& ec)
>  {
>      if (canPlay())
> -	   play(ec);
> +	   playInternal(ec);
>      else 
> -	   pause(ec);
> +	   pauseInternal(ec);
>  }

Maybe add a comment to say why it's always OK to call the
internal methods.

> Index: WebCore/html/HTMLMediaElement.h
> ===================================================================

> +    void loadInternal(ExceptionCode& ec);
> +    void playInternal(ExceptionCode& ec);
> +    void pauseInternal(ExceptionCode& ec);

Add a comment to say why these are needed.