[webkit-reviews] review denied: [Bug 24043] [GTK] Workers with url 'about:blank' do not load : [Attachment 27820] Check URL prior to loading it in SubresourceLoader

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 19 23:23:11 PST 2009


Alexey Proskuryakov <ap at webkit.org> has denied Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 24043: [GTK] Workers with url 'about:blank' do not load
https://bugs.webkit.org/show_bug.cgi?id=24043

Attachment 27820: Check URL prior to loading it in SubresourceLoader
https://bugs.webkit.org/attachment.cgi?id=27820&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
I don't think that this is correct - trying to load about:blank as a non-main
resource should result in a failure due to unknown protocol in the loader (just
like any foo:bar URL would). There is no reason to special-case "about:".

Why does this test time out? It doesn't use
layoutTestController.waitUntilDone(), and it doesn't depend on the results of
loading the worker script in any way that I could see.


More information about the webkit-reviews mailing list