[webkit-reviews] review granted: [Bug 24046] Misc improvements to CString : [Attachment 27816] v1 patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Feb 19 16:59:57 PST 2009
Eric Seidel <eric at webkit.org> has granted Darin Fisher (:fishd, Google)
<darin at chromium.org>'s request for review:
Bug 24046: Misc improvements to CString
https://bugs.webkit.org/show_bug.cgi?id=24046
Attachment 27816: v1 patch
https://bugs.webkit.org/attachment.cgi?id=27816&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
This looks fine. It's kinda sad how we're growing a parallel string class
here, but that happened long ago, and was inevitable based on how many APIs
outside of WebKit depend on char* strings. (And doesn't really relate to this
patch.)
releaseBuffer() was not used anywhere? I'm surprised.
Looks fine.
More information about the webkit-reviews
mailing list