[webkit-reviews] review granted: [Bug 23999] Split off MIME Type parsing into its own class : [Attachment 27750] Split off MIME type parsing into its own class, v2

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 23999: Split off MIME Type parsing into its own class
https://bugs.webkit.org/show_bug.cgi?id=23999

Attachment 27750: Split off MIME type parsing into its own class, v2
https://bugs.webkit.org/attachment.cgi?id=27750&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
r=me

> +		       if (!MediaPlayer::supportsType(contentType.type(),
contentType.parameter("codecs")))
>			   continue;

It would be nice to make MediaPlayer::supportsType just take ContentType. Does
not need to be in this patch though...

> +    class ContentType {
> +    public:
> +	   ContentType(const String& type);
> +
> +	   String parameter(const String& parameterName);
> +	   String type();

These can be const.