[webkit-reviews] review requested: [Bug 19221] ASSERT during Range creation (due to editing commands) : [Attachment 27814] Complete fix, including ap's suggested cleanup of rangeCompliantEquivalent callers

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has asked  for review:
Bug 19221: ASSERT during Range creation (due to editing commands)
https://bugs.webkit.org/show_bug.cgi?id=19221

Attachment 27814: Complete fix, including ap's suggested cleanup of
rangeCompliantEquivalent callers
https://bugs.webkit.org/attachment.cgi?id=27814&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
 LayoutTests/ChangeLog				    |	15 ++++++
 .../assert-on-range-creation-expected.txt	    |	 1 +
 .../execCommand/assert-on-range-creation.html	    |	12 +++++
 WebCore/ChangeLog				    |	46 ++++++++++++++++++++
 WebCore/dom/Range.cpp				    |	 7 +++-
 WebCore/dom/Range.h				    |	 2 +
 WebCore/editing/ApplyStyleCommand.cpp		    |	 4 +-
 WebCore/editing/CompositeEditCommand.cpp	    |	20 ++++-----
 WebCore/editing/DeleteSelectionCommand.cpp	    |	 4 +-
 WebCore/editing/Editor.cpp			    |	 2 +-
 WebCore/editing/VisiblePosition.cpp		    |	 2 +-
 WebCore/editing/VisibleSelection.cpp		    |	 8 +---
 WebCore/editing/htmlediting.cpp		    |	 6 ++-
 WebCore/editing/visible_units.cpp		    |	34 +++++++--------
 WebCore/page/DOMSelection.cpp			    |	12 ++---
 15 files changed, 124 insertions(+), 51 deletions(-)