[webkit-reviews] review granted: [Bug 24017] Remove some usage of Document in Worker. : [Attachment 27808] Updated patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 19 14:22:15 PST 2009


Alexey Proskuryakov <ap at webkit.org> has granted Dmitry Titov
<dimich at chromium.org>'s request for review:
Bug 24017: Remove some usage of Document in Worker.
https://bugs.webkit.org/show_bug.cgi?id=24017

Attachment 27808: Updated patch.
https://bugs.webkit.org/attachment.cgi?id=27808&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
r=me

> +	   virtual String userAgent(const KURL&) const { return m_userAgent; }

There isn't much good in inlining this virtual function - it is unlikely to
ever be called in a way that can be inlined. There also isn't a lot of use in
keeping the implementation in header as documentation, nor a significant win in
brevity.


More information about the webkit-reviews mailing list