[webkit-reviews] review requested: [Bug 23980] WorkerRunLoop needs a way to run in a given mode similar to CFRunLoopInMode. : [Attachment 27795] Proposed fix.

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has asked  for review:
Bug 23980: WorkerRunLoop needs a way to run in a given mode similar to
CFRunLoopInMode.
https://bugs.webkit.org/show_bug.cgi?id=23980

Attachment 27795: Proposed fix.
https://bugs.webkit.org/attachment.cgi?id=27795&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Addressed comments.

> Generally, I'm not sure how a task that can be served in multiple modes will
> work. Is this not implemented yet, or am I missing something? 
Not implemented yet.  I'd like to discuss some details around your scenario. 
I'll find you in irc or email you, but regardless as if needed, I'll do this in
a future change.


> As commented in another bug, I wonder if we need
waitForMessageFilteredWithTimeout.
I like this idea.  How about if I do it in another patch right after this? (I'm
thinking about adding an Infinite constant that can be passed in and then just
collapsing some of the if's in runInMode.  I'd also like to remove duplicate
code in MessageQueue (as long as it is still readable).


> A brief description of the API in ChangeLog would be nice.
Added something that I like, but I may not have been brief enough ?