[webkit-reviews] review granted: [Bug 24011] KURL's setPort doesn't unset port if 0 is given : [Attachment 27765] proposed fix

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Gustavo Noronha (kov)
<gns at gnome.org>'s request for review:
Bug 24011: KURL's setPort doesn't unset port if 0 is given
https://bugs.webkit.org/show_bug.cgi?id=24011

Attachment 27765: proposed fix
https://bugs.webkit.org/attachment.cgi?id=27765&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
r=me

> +	   Make setPort remove port if 0 is given to it, as promissed by the

Typo: should be "promised".

>      // FIXME: Non-ASCII characters must be encoded and escaped to match
parse() expectations,
>      // and to avoid changing more than just the port.

Oops, this FIXME is totally bogus - this method takes a number, so there is no
need to encode it! Please feel free to remove it if you wish.

> +    if (!i)

We'd normally put the normal code path first (if (i)).